Skip to content

Regression: Repair CodeMirror component reactivity #18037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 1 commit into from
Jun 25, 2020
Merged

Regression: Repair CodeMirror component reactivity #18037

ggazzo merged 1 commit into from
Jun 25, 2020

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jun 24, 2020

Proposed changes

Settings with the type code are shown as duplicated CodeMirror editors on Administration and App Details pages.

Issue(s)

How to test or reproduce

Open Administration > Accounts or Administration > General.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan added type: bug area: ui Touches the code on client side labels Jun 24, 2020
@tassoevan tassoevan added this to the 3.4.0 milestone Jun 24, 2020
@tassoevan tassoevan requested a review from a team June 24, 2020 22:40
@ggazzo ggazzo merged commit dbe4d17 into develop Jun 25, 2020
@ggazzo ggazzo deleted the regression/code-setting-input branch June 25, 2020 02:55
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

area: ui Touches the code on client side type: bug

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tassoevan @ggazzo